Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

Conversation

@velovint
Copy link

Allow to fetch source from branch or tag where they were pushed using "ref" attribute in web hook.
Branch mask may later be configured. In our case webhook on git tag event sufficiently limits what needs to be cloned into S3.

Supersedes #22

@velovint
Copy link
Author

@jaymccon is there a particular reason to checkout each branch into own subdir? I removed that part to reuse workspace and not clone the same code over and over again. It also makes things a bit trickier with tags when you and end in detached head, so it seems better to me.

@JuHwon
Copy link

JuHwon commented Jul 9, 2018

@velovint i use seperate subfolders for every branch to create different code pipelines for each subfolder.
this feature is mandatory for me.

@velovint
Copy link
Author

@JuHwon sorry for delay. I'll try to restore subfolder per branch functionality.

@velovint
Copy link
Author

@JuHwon I checked changes in repository you cloned and found out that we're talking about 2 different things. I was asking about a branch specific working directory for lambda function when pulling and zipping source while you need a branch specific zip file in S3.

Your changes totally make sense to me, but I suggest to make them in separate pull request as they modify external behavior and will at least require changes to quickstart guide document.

@velovint
Copy link
Author

@jaymccon how can I help to get this PR merged?

@EvertVerboven
Copy link

EvertVerboven commented Jun 21, 2019

Is this going te be released soon. It seems that this is quite an important feature. No point in having a webhook listen to a specific branch while the lambda just always pulls master.

EDIT: The current behaviour should also be beter documented in the deployment guide and readme.

@jaymccon jaymccon merged commit 7e1450c into aws-quickstart:develop Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants